[Kde-pim] Review Request 127530: Drop unnecessary QtWebKitWidgets and QtUiTools dependencies

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127530/#review94141
-----------------------------------------------------------


Ship it!




Looks good, removing unused deps is OK for 16.04.

- Daniel Vrátil


On March 30, 2016, 11:34 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127530/
> -----------------------------------------------------------
> 
> (Updated March 30, 2016, 11:34 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: incidenceeditor
> 
> 
> Description
> -------
> 
> Drop unnecessary QtWebKitWidgets and QtUiTools dependencies
> 
> UiTools is only referenced in the find_package call and despite
> Qt5::WebKitWidgets being mentioned in target_link_libraries I could
> not find any actual usage.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt af41e99f86fbe8f5c06ed6808853f9a8a0f139dc 
>   tests/CMakeLists.txt 143ed2cff3fce3eded41ab0ab8df64345501bd41 
> 
> Diff: https://git.reviewboard.kde.org/r/127530/diff/
> 
> 
> Testing
> -------
> 
> Still compiles and passes its tests.
> 
> (Not sure which branch to target, but since I have been asked to cherry-pick a similar change to Applications/16.04 I have gone with that.)
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/