[Kde-pim] Review Request 127181: Add a 'trust owner' dialog for newly imported secret keys

[Sean Engelhardt]

> On Feb. 26, 2016, 9:58 a.m., Andre Heinecke wrote:
> > kleopatra/commands/importcertificatescommand.cpp, line 414
> > <https://git.reviewboard.kde.org/r/127181/diff/1/?file=445483#file445483line414>
> >
> >     Are you sure this is always the finterprint of the primary key? E.g. what happens if you import a secret key that was already imported but only had a subkey added?
> 
> Andre Heinecke wrote:
>     Talked about this with sean directly. Kleo currently does not handle it correctly if you import a secret key that only has new subkeys. Thats a different issue. And I don't know how the Import API is supposed to behave in that case.

I cannot test this scenario. Kleo does not import or enhances or overwirtes altered certificates.

see: https://bugs.kde.org/show_bug.cgi?id=359954


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127181/#review92800
-----------------------------------------------------------


On March 10, 2016, 12:04 p.m., Sean Engelhardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127181/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 12:04 p.m.)
> 
> 
> Review request for KDEPIM and Andre Heinecke.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> When importing a new secret key in Kleopatra, a dialog-window will pop up to determinate if the owner of the newly imported key should be trusted or not.
> Since imported secret keys are usually the own ones it would make sense to enhance the trusting-process.
> 
> 
> Diffs
> -----
> 
>   kleopatra/commands/importcertificatescommand.cpp 18a65d1 
> 
> Diff: https://git.reviewboard.kde.org/r/127181/diff/
> 
> 
> Testing
> -------
> 
> Imported newly generated keys to determinate if the script gets triggered and works as requested.
> 
> -edited version after the 1. reviewing process. Changed according to the requests. Propably found a bug in kleo.
> 
> -edited version after the 2. reviewing process. Changed the spaches beforce and after the braces, removed logging for S/Mime keys, adjusted the dialog.
> 
> 
> Thanks,
> 
> Sean Engelhardt
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/