[Kde-pim] Review Request 127181: Add a 'trust owner' dialog for newly imported secret keys

[Andre Heinecke]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127181/#review93386
-----------------------------------------------------------


Ship it!




Thanks. I'll probably change the string in the dialog some more. But this doesn't need to be part of the review request.

- Andre Heinecke


On March 10, 2016, 12:04 p.m., Sean Engelhardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127181/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 12:04 p.m.)
> 
> 
> Review request for KDEPIM and Andre Heinecke.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> When importing a new secret key in Kleopatra, a dialog-window will pop up to determinate if the owner of the newly imported key should be trusted or not.
> Since imported secret keys are usually the own ones it would make sense to enhance the trusting-process.
> 
> 
> Diffs
> -----
> 
>   kleopatra/commands/importcertificatescommand.cpp 18a65d1 
> 
> Diff: https://git.reviewboard.kde.org/r/127181/diff/
> 
> 
> Testing
> -------
> 
> Imported newly generated keys to determinate if the script gets triggered and works as requested.
> 
> -edited version after the 1. reviewing process. Changed according to the requests. Propably found a bug in kleo.
> 
> -edited version after the 2. reviewing process. Changed the spaches beforce and after the braces, removed logging for S/Mime keys, adjusted the dialog.
> 
> 
> Thanks,
> 
> Sean Engelhardt
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/