[Kde-pim] [Differential] [Commented On] D1990: Show spam status in 5.2 header

[dvratil (Daniel Vrátil)]

dvratil added inline comments.

INLINE COMMENTS

> knauss wrote in header.html:83
> (a little bit unrelated)
> shouldn't we switch to use i18n  grantlee support? I think it is much more readable if we do the translation directly in the grantlee itself and we can fix more easily forgotten untranslated strings like Sender/List-Id in this case:
> 
>      [...]
>       {% if header.ListId %}
>       <div class="row">
>   	​      <div class="headerleft">{% i18n "List-Id:" %}</div>
>   	​      <div class="headerright">{{ header.ListId }}</div>
>       </div>
>       {% endif %}
>       <div class="row">
>   	​      <div class="headerleft">{% i18n "Date:" %}</div>
>   	​      <div class="headerrightdate" dir="{{ dateDir }}">{{ header.dateshort }}</div>
>       </div>
>      {% if header.spamHTML %}
>   	   <div class="row">
>   	​      <div class="headerleft">{% i18n "Spam status:" %}</div>
>     [...]

The advantage of having the strings coming from KMail is that it also provides localization for 3rd party themes.

(the harcoded List-Id string is wrong of course, should be also localizable).

REPOSITORY
  rKDEPIMADDONS KDE PIM Addons

REVISION DETAIL
  https://phabricator.kde.org/D1990

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: knauss, colomar, mlaurent
Cc: dvratil, kde-pim, dvasin, winterz, smartins, vkrause, mlaurent, knauss
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/