[Kde-pim] Review Request 128383: Fix bug with events ending at midnight
Bastian Köcher
identity.kde at kchr.de
Sun Jul 10 22:35:28 BST 2016
> On Juli 10, 2016, 9:01 nachm., Bastian Köcher wrote:
> > Ship It!
>
> Luca Beltrame wrote:
> Do you have commit access? If not, you can ask other people to commit it for you. Unfortunately, hitting "Ship it" youself won't magically merge the code. ;)
YYeah sorry for spaming you :( Pressed the button multiple times and realized too late that this would send emails.
AAlready asked Sandro to merge it for me.
- Bastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128383/#review97269
-----------------------------------------------------------
On Juli 10, 2016, 9:01 nachm., Bastian Köcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128383/
> -----------------------------------------------------------
>
> (Updated Juli 10, 2016, 9:01 nachm.)
>
>
> Review request for KDEPIM, Sandro Knauß and Allen Winter.
>
>
> Bugs: 362921
> https://bugs.kde.org/show_bug.cgi?id=362921
>
>
> Repository: kcalcore
>
>
> Description
> -------
>
> This fixes the bug with events that end at midnight and are displayed for multiple days.
>
>
> Diffs
> -----
>
> autotests/testevent.h edb5ef7
> autotests/testevent.cpp 25ffbec
> src/event.cpp 840905e
>
> Diff: https://git.reviewboard.kde.org/r/128383/diff/
>
>
> Testing
> -------
>
> make test hangs at "Start 368: RecursOn-RFC2445_RRULETest39.ics", but without my change is seems to be hanging there too.
>
>
> File Attachments
> ----------------
>
> patch
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/10/61a932a1-b99a-4554-8a56-4c9d7ef7771f__patch
>
>
> Thanks,
>
> Bastian Köcher
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list