[Kde-pim] Review Request 128383: Fix bug with events ending at midnight

[Sandro Knauß]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128383/#review97266
-----------------------------------------------------------


Fix it, then Ship it!




After that - feel free to ship it directly.


autotests/testevent.cpp (line 276)
<https://git.reviewboard.kde.org/r/128383/#comment65666>

    Please collapse the four lines into one like this:
    
      QTest::newRow("event0") <<  KDateTime(QDate(2016, 7, 9), QTime(12, 0, 0)) << KDateTime(QDate(2016, 7, 9), QTime(13, 0, 0))<< false;


- Sandro Knauß


On July 9, 2016, 6:12 p.m., Bastian Köcher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128383/
> -----------------------------------------------------------
> 
> (Updated July 9, 2016, 6:12 p.m.)
> 
> 
> Review request for KDEPIM, Sandro Knauß and Allen Winter.
> 
> 
> Bugs: 362921
>     https://bugs.kde.org/show_bug.cgi?id=362921
> 
> 
> Repository: kcalcore
> 
> 
> Description
> -------
> 
> This fixes the bug with events that end at midnight and are displayed for multiple days.
> 
> 
> Diffs
> -----
> 
>   autotests/testevent.h edb5ef7 
>   autotests/testevent.cpp 25ffbec 
>   src/event.cpp 840905e 
> 
> Diff: https://git.reviewboard.kde.org/r/128383/diff/
> 
> 
> Testing
> -------
> 
> make test hangs at "Start 368: RecursOn-RFC2445_RRULETest39.ics", but without my change is seems to be hanging there too.
> 
> 
> Thanks,
> 
> Bastian Köcher
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/