[Kde-pim] [Differential] [Commented On] D2038: A new akonadi resource type implementing the Tomboy REST API

[knauss (Sandro Knauß)]

knauss added inline comments.

INLINE COMMENTS

> CMakeLists.txt:137
>  
> -
>  add_subdirectory(resources)

please no unrelated added/deleted newlines, they make it quite harder to use git blame f.ex.

> acknowledgements.md:19
> +>      derived from this software without specific prior written permission.
> +> 
> +> THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND

This license is not Debian compatible ( https://www.debian.org/social_contract.html#guidelines), because:

- Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.

This means you need to write the copyright, if you use the software: "Copyright (c) 2011, Andre Somers"

and the part:

- Neither the name of the Rathenau Instituut, Andre Somers nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission.

So you need to ask Andre Somers before redistrubution, becuase his name is paort of the copyright and this is against the DFSG #1, because you have a "royality" how can deside if you can redistrubute or not. And do not hold in the "Desert Island" test (https://people.debian.org/~bap/dfsg-faq.html)

REPOSITORY
  rKDEPIMRUNTIME KDE PIM Runtime

REVISION DETAIL
  https://phabricator.kde.org/D2038

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: Stefan, #kde_pim, dvratil
Cc: krake, mlaurent, knauss, dvratil, kde-pim, dvasin, winterz, smartins, vkrause
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/