[Kde-pim] Review Request 126971: Add "Copy Decrypted Message To..." action to message list

[Andre Heinecke]

> On Feb. 2, 2016, 6:39 p.m., Sandro Knauß wrote:
> > Well it would be good also to add a testcase for the new feature.
> > see https://phabricator.kde.org/D892, there I have already created one testcase for reply/forward.
> 
> Andre Heinecke wrote:
>     Not neccessary for the vendor/intevation branch :-/ sorry.
> 
> Sandro Knauß wrote:
>     I totalty like this feature and also want to see this in master. And to have features only in one branch is not a good idea either. Yes it is not neccessary, but it is better to create one :)
> 
> Daniel Vrátil wrote:
>     I will take care of getting this on master as well eventually (there will be more changes coming), including proper tests. It might need some changes related to your OTP work as well.
>     
>     Might be interesting to try to make it a kdepim-addon (a plugin) rather than a hard-coded feature like that - the message context menu is already super-long by default :)

For master we might want a different solution that works closer to akonadi. Some kind of Job or so. We need something like that for the easygpg project to handle crypto policies that work on all incoming mails and large archives. (btw. we will publicly announcing that we will be working on that, later or in the next days). I think using the Objectreeparser / Kmail for this is not the best solution (but the easiest). E.g. this patch blocks Kontact / KMail while decryption is done. (Which can easily take quite some time on many mails with large keys and or smartcards)


- Andre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126971/#review91985
-----------------------------------------------------------


On Feb. 2, 2016, 4:32 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126971/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 4:32 p.m.)
> 
> 
> Review request for KDEPIM, Andre Heinecke and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> This adds a new action to message context menu that allows to create a decrypted copy of an existing email. Based on the e3 patches from aheinecke.
> 
> 
> Diffs
> -----
> 
>   kmail/kmail_part.rc db3c27b 
>   kmail/kmcommands.h 1208da1 
>   kmail/kmcommands.cpp f7f06e92 
>   kmail/kmmainwidget.h 68f57a1 
>   kmail/kmmainwidget.cpp 02bedaa 
>   kmail/kmmainwin.rc db3c27b 
> 
> Diff: https://git.reviewboard.kde.org/r/126971/diff/
> 
> 
> Testing
> -------
> 
> Tested with S/MIME and PGP encrypted emails. Inner signatures are preserved. The only issue I noticed is that encrypted emails with outter signature are marked as "bad", which is to be expected. The e3 patches mention something about stripping outter signatures, but I could not really test what the original code was doing :)
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/