[Kde-pim] Review Request 126971: Add "Copy Decrypted Message To..." action to message list

[Andre Heinecke]

> On Feb. 2, 2016, 6:39 p.m., Sandro Knauß wrote:
> > Well it would be good also to add a testcase for the new feature.
> > see https://phabricator.kde.org/D892, there I have already created one testcase for reply/forward.

Not neccessary for the vendor/intevation branch :-/ sorry.


> On Feb. 2, 2016, 6:39 p.m., Sandro Knauß wrote:
> > kmail/kmmainwidget.cpp, line 3061
> > <https://git.reviewboard.kde.org/r/126971/diff/2/?file=442586#file442586line3061>
> >
> >     only add if the message is encrypted, if that is possible in that step.

No you want to have that action for example if you select lots of mails even if some of them are not encrypted. In case they are not you only store a plain copy. Adding logic here to figure out if one of the selected messages is encrypted is problematic and out of scope.


- Andre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126971/#review91985
-----------------------------------------------------------


On Feb. 2, 2016, 4:32 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126971/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 4:32 p.m.)
> 
> 
> Review request for KDEPIM, Andre Heinecke and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> This adds a new action to message context menu that allows to create a decrypted copy of an existing email. Based on the e3 patches from aheinecke.
> 
> 
> Diffs
> -----
> 
>   kmail/kmail_part.rc db3c27b 
>   kmail/kmcommands.h 1208da1 
>   kmail/kmcommands.cpp f7f06e92 
>   kmail/kmmainwidget.h 68f57a1 
>   kmail/kmmainwidget.cpp 02bedaa 
>   kmail/kmmainwin.rc db3c27b 
> 
> Diff: https://git.reviewboard.kde.org/r/126971/diff/
> 
> 
> Testing
> -------
> 
> Tested with S/MIME and PGP encrypted emails. Inner signatures are preserved. The only issue I noticed is that encrypted emails with outter signature are marked as "bad", which is to be expected. The e3 patches mention something about stripping outter signatures, but I could not really test what the original code was doing :)
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/