[Kde-pim] Review Request 127099: Fix formatting in Kleopatra selftest details

[Andre Heinecke]

> On Feb. 17, 2016, 5:11 p.m., Laurent Montel wrote:
> > If we don't change i18n, I write ship it.

As this is a very rarely run codepath I think It's better here to waste a little string allocation to avoid messing with a i18n'ed string. So I'll commit this.


- Andre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127099/#review92504
-----------------------------------------------------------


On Feb. 17, 2016, 4:25 p.m., Andre Heinecke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127099/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2016, 4:25 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> xi18nc escapes richtext in arguments so the messages are not formated. So this patch bypasses xi18nc argument extension by using QString argument extension.
> 
> This looks a bit hackish to me and I'm not sure if there is a better solution (without modifying the translated string). Hence the review.
> 
> 
> Diffs
> -----
> 
>   kleopatra/selftest/libkleopatrarccheck.cpp dba588b 
> 
> Diff: https://git.reviewboard.kde.org/r/127099/diff/
> 
> 
> Testing
> -------
> 
> Tested that the message is still translated and shows up correctly. (with formatting now)
> 
> 
> File Attachments
> ----------------
> 
> Before the change (german)
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/17/620c5411-fe7d-407e-af8a-d3366fd9dfb6__kleo-self-details-old.png
> After the change
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/17/2af916a6-6567-4bb8-b9d8-48243aa9990d__kleo-self-details-new.png
> 
> 
> Thanks,
> 
> Andre Heinecke
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/