[Kde-pim] Review Request 126974: [kleopatra] Fix standalone build

[Andre Heinecke]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126974/#review92007
-----------------------------------------------------------



Thanks for trying this out.


kleopatra/CMakeLists.txt (line 11)
<https://git.reviewboard.kde.org/r/126974/#comment62767>

    Oops. Forgot this. But the Variable used later on is just called LIBKDEPIM_VERSION (to be more in line with the rest of the variables)
    
    But you can just leave that out. I have a patch I'll put up for review later that will remove the Libkdepim dependency and for Kleopatra any Version of Libkdepim is fine anyway.



kleopatra/CMakeLists.txt (line 12)
<https://git.reviewboard.kde.org/r/126974/#comment62764>

    KPimtextedit is a optional dependency of Libkleo. We should probably bump libkleo version version for standalone build and fix it in the libkleo config script that it pulls in that dependency if neccessary. I'll look at this now. Not sure how to handle optional dependencies correctly in a cmake config.
    
    But I'd like to be able to build kleopatra without a dependency to KPIMTEXTEDIT for gpg4win.



kleopatra/CMakeLists.txt (line 89)
<https://git.reviewboard.kde.org/r/126974/#comment62776>

    Ok. I did not need this in my build setup. Maybe because I have assuan installed in the same prefix as gpgme. But if it is neccessary for you we should add this.


- Andre Heinecke


On Feb. 3, 2016, 12:43 a.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126974/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 12:43 a.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> - FindGpgme is necessary (using gpgme.h directly)
> - Find KF5PimTextEdit
> - Add missing version setters
> 
> 
> Diffs
> -----
> 
>   kleopatra/CMakeLists.txt 4196f8da74ab0c3e49ccd652d818f8d19f3b60d7 
>   kleopatra/cmake/modules/FindGpgme.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126974/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/