[Kde-pim] Review Request 126974: [kleopatra] Fix standalone build

[Andre Heinecke]

> On Feb. 3, 2016, 9:41 a.m., Andre Heinecke wrote:
> > kleopatra/CMakeLists.txt, line 14
> > <https://git.reviewboard.kde.org/r/126974/diff/1/?file=442607#file442607line14>
> >
> >     KPimtextedit is a optional dependency of Libkleo. We should probably bump libkleo version version for standalone build and fix it in the libkleo config script that it pulls in that dependency if neccessary. I'll look at this now. Not sure how to handle optional dependencies correctly in a cmake config.
> >     
> >     But I'd like to be able to build kleopatra without a dependency to KPIMTEXTEDIT for gpg4win.
> 
> Andreas Sturmlechner wrote:
>     Ah yes, I've seen that commit in libkleo. Maybe kpimtextedit just needs to be made private?

Yes Of course. I accidentally declared it to be public when making it optional. It was private before. I just fixed it. http://commits.kde.org/libkleo/3c7255c68725b264d9b58d9e474a86fc6c132bda
This also makes it clear to me why there are not more dependencies in the config script as they are all also Private.
Sorry and thanks for pointing this out. I should have opened a review request for the optional change in libkleo but I thought it was small enough to do without. :-/


- Andre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126974/#review92007
-----------------------------------------------------------


On Feb. 3, 2016, 12:43 a.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126974/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 12:43 a.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> - FindGpgme is necessary (using gpgme.h directly)
> - Find KF5PimTextEdit
> 
> 
> Diffs
> -----
> 
>   kleopatra/CMakeLists.txt 4196f8da74ab0c3e49ccd652d818f8d19f3b60d7 
>   kleopatra/cmake/modules/FindGpgme.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126974/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/