[Kde-pim] [Differential] [Updated, 154 lines] D994: [WIP] Parse .desktop files with KConfig

elvisangelaccio (Elvis Angelaccio) noreply at phabricator.kde.org
Mon Feb 22 10:47:12 GMT 2016


elvisangelaccio updated this revision to Diff 2429.
elvisangelaccio added a comment.


  Since KConfig handles localization for us, I replaced the two QHash members
  (name and comment) with simple strings. This required to remove a bunch of
  related dbus methods, which I hope are not called by someone else (?).
  
  I also had to update the autotest (which now passes), since apparently KConfig doesn't like
  escaped quotes. Indeed if a field has value "foo", the actual parsed string is
  "\"foo\"", so quotes are automatically escaped during parsing.

REPOSITORY
  rAKONADI Akonadi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D994?vs=2404&id=2429

BRANCH
  kconfig-parser-desktopfiles

REVISION DETAIL
  https://phabricator.kde.org/D994

AFFECTED FILES
  autotests/akonadicontrol/CMakeLists.txt
  autotests/akonadicontrol/agenttypetest.cpp
  autotests/akonadicontrol/data/googlecontactsresource.desktop
  src/akonadicontrol/CMakeLists.txt
  src/akonadicontrol/agentmanager.cpp
  src/akonadicontrol/agentmanager.h
  src/akonadicontrol/agenttype.cpp
  src/akonadicontrol/agenttype.h
  src/core/agentmanager.cpp
  src/interfaces/org.freedesktop.Akonadi.AgentManager.xml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, dvratil
Cc: kde-pim, winterz, smartins, vkrause, mlaurent, mbohlender, knauss, dvratil
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list