Review Request 129667: Fix calendar system checks for pascha
Chusslove Illich
caslav.ilic at gmx.net
Sun Dec 18 12:07:51 GMT 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129667/
-----------------------------------------------------------
(Updated Дец. 18, 2016, 1:07 по п.)
Review request for KDEPIM and John Layt.
Repository: kholidays
Description (updated)
-------
Date of pascha is currently computed wrongly. Commit b47ddff6 (switch from KCalendarSystem to QCalendarSystem) reversed all calendar system checks from equality to inequality in HolidayParserDriverPlan::pascha(), it seems to me by error (e.g. the first check is always true after the change). After reverting to equality checks, pascha date computation is correct.
Diffs
-----
src/parsers/plan2/holidayparserdriverplan.cpp 940dfe5
Diff: https://git.reviewboard.kde.org/r/129667/diff/
Testing
-------
Thanks,
Chusslove Illich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161218/5e3f0142/attachment.html>
More information about the kde-pim
mailing list