Review Request 129667: Fix calendar system checks for pascha

Chusslove Illich caslav.ilic at gmx.net
Sun Dec 18 11:35:46 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129667/
-----------------------------------------------------------

Review request for KDEPIM and John Layt.


Repository: kholidays


Description
-------

Date of pascha is currently computed wrongly. Commit b47ddff6 (switch from KCalendarSystemQCalendarSystem) reversed all calendar system checks from equality to inequality in HolidayParserDriverPlan::pascha(), it seems to me by error (e.g. the first check is always true after the change). After reverting to equality checks, pascha date computation is correct.


Diffs
-----

  src/parsers/plan2/holidayparserdriverplan.cpp 940dfe5 

Diff: https://git.reviewboard.kde.org/r/129667/diff/


Testing
-------


Thanks,

Chusslove Illich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161218/c59be4b7/attachment.html>


More information about the kde-pim mailing list