Review Request 128755: [Akregator] Managing more feeds for notification event

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128755/#review98670
-----------------------------------------------------------


Ship it!




Seems good.
Ship it.
I will commit it.
Thanks.

- Laurent Montel


On Aug. 25, 2016, 1:41 p.m., Giuseppe Calà wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128755/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2016, 1:41 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> This is a new fix for articles notification.
> 
> My previous patch had two issues:
> 
> - did not consider that m_articles can provide articles from more feeds
> - lack of closing (if needed) for feeds when exiting from Q_FOREACH loop
> 
> 
> P.S. I not have permission to commit the patch.
> 
> 
> Diffs
> -----
> 
>   akregator/src/notificationmanager.cpp c89980e 
> 
> Diff: https://git.reviewboard.kde.org/r/128755/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Giuseppe Calà
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160826/aa966577/attachment.html>