Review Request 128755: [Akregator] Managing more feeds for notification event
Giuseppe Calà
jiveaxe at gmail.com
Fri Aug 26 05:56:02 BST 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128755/
-----------------------------------------------------------
(Updated Aug. 26, 2016, 12:56 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDEPIM.
Changes
-------
Submitted with commit 797930bd13720a47745e815a48ed32360103f39d by Montel Laurent to branch master.
Repository: kdepim
Description
-------
This is a new fix for articles notification.
My previous patch had two issues:
- did not consider that m_articles can provide articles from more feeds
- lack of closing (if needed) for feeds when exiting from Q_FOREACH loop
P.S. I not have permission to commit the patch.
Diffs
-----
akregator/src/notificationmanager.cpp c89980e
Diff: https://git.reviewboard.kde.org/r/128755/diff/
Testing
-------
Thanks,
Giuseppe Calà
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160826/d4622a61/attachment.html>
More information about the kde-pim
mailing list