[Differential] [Commented On] D2434: Cache tags by name instead of gid

[knauss (Sandro Knauß)]

knauss added inline comments.

INLINE COMMENTS

> tagcache.h:58
>      QHash<QByteArray, Akonadi::Tag::Id> mGidCache;
> +    QHash<QByteArray, Akonadi::Tag::Id> mNameCache;
>      Akonadi::Monitor *mMonitor;

I would suggest QHash<QString, Akonadi::Tag::Id>, becuase the name is actually a QString, so no need to convert it to/from a QString.

REPOSITORY
  rCALENDARSUPPORT PIM: Calendar Support

REVISION DETAIL
  https://phabricator.kde.org/D2434

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dkurz, #kde_pim
Cc: knauss, kde-pim, spencerb, dvasin, winterz, smartins, vkrause, mlaurent, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160814/79120f1c/attachment.html>