<table><tr><td style="">knauss added inline comments.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2434" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2434#inline-9799" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tagcache.h:58</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QHash</span><span style="color: #aa2211"><</span><span class="n">QByteArray</span><span class="p">,</span> <span class="n">Akonadi</span><span style="color: #aa2211">::</span><span class="n">Tag</span><span style="color: #aa2211">::</span><span class="n">Id</span><span style="color: #aa2211">></span> <span class="n">mGidCache</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">QHash</span><span style="color: #aa2211"><</span><span class="n">QByteArray</span><span class="p">,</span> <span class="n">Akonadi</span><span style="color: #aa2211">::</span><span class="n">Tag</span><span style="color: #aa2211">::</span><span class="n">Id</span><span style="color: #aa2211">></span> <span class="n">mNameCache</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">Akonadi</span><span style="color: #aa2211">::</span><span class="n">Monitor</span> <span style="color: #aa2211">*</span><span class="n">mMonitor</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I would suggest QHash<QString, Akonadi::Tag::Id>, becuase the name is actually a QString, so no need to convert it to/from a QString.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rCALENDARSUPPORT PIM: Calendar Support</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2434" rel="noreferrer">https://phabricator.kde.org/D2434</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>dkurz, KDE PIM<br /><strong>Cc: </strong>knauss, kde-pim, spencerb, dvasin, winterz, smartins, vkrause, mlaurent, dvratil<br /></div>