Review Request 128722: [WIP] [kdepim-apps-libs] Set all blacklisted keys to its upper case version
Laurent Montel
montel at kde.org
Mon Aug 22 15:29:52 BST 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128722/#review98553
-----------------------------------------------------------
I didn't read code but branch 16.08 is not the good branch for a big changes as it it's master for it.
- Laurent Montel
On Aug. 20, 2016, 6:59 p.m., Bernhard Scheirle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128722/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2016, 6:59 p.m.)
>
>
> Review request for KDEPIM and Laurent Montel.
>
>
> Bugs: 317966
> https://bugs.kde.org/show_bug.cgi?id=317966
>
>
> Repository: kdepim-apps-libs
>
>
> Description
> -------
>
> Set all blacklisted keys to its upper case version. This is needed since all KContacts::Addressee custom fields are now upper case.
> Please also see the review request for KContacts: https://git.reviewboard.kde.org/r/128724
>
>
> Diffs
> -----
>
> kaddressbookgrantlee/src/formatter/grantleecontactformatter.cpp c626aa7
>
> Diff: https://git.reviewboard.kde.org/r/128722/diff/
>
>
> Testing
> -------
>
> ctest passes.
>
>
> Thanks,
>
> Bernhard Scheirle
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160822/921fbb42/attachment.html>
More information about the kde-pim
mailing list