Review Request 128723: [WIP] [akonadi-contacts] Set all blacklisted keys to its upper case version

[Bernhard Scheirle]

> On Aug. 22, 2016, 11:22 a.m., Daniel Vrátil wrote:
> > As you mentioned in https://git.reviewboard.kde.org/r/128724/, the RFC dictates that the comparision should be case-insensitive. In other words, this won't work with data from other (or older) clients which generate lower-case strings. You should thus do a case-insensitive lookup. QSet does not have any such API, but you can use std::find_if with custom predicate using QString::compare.

Why does this not work? I explicitly call toUpper before comparing the key with the blacklist.


- Bernhard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128723/#review98546
-----------------------------------------------------------


On Aug. 20, 2016, 8:59 p.m., Bernhard Scheirle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128723/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2016, 8:59 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Bugs: 317966
>     https://bugs.kde.org/show_bug.cgi?id=317966
> 
> 
> Repository: akonadi-contacts
> 
> 
> Description
> -------
> 
> Set all blacklisted keys to its upper case version. This is needed since all KContacts::Addressee custom fields are now upper case.
> Please also see the review request for KContacts: https://git.reviewboard.kde.org/r/128724
> 
> 
> Diffs
> -----
> 
>   src/editor/customfieldeditor/customfieldslistwidget.cpp 028da8cb6410193a59047c3449cc36ccf2a80c74 
> 
> Diff: https://git.reviewboard.kde.org/r/128723/diff/
> 
> 
> Testing
> -------
> 
> ctest passes.
> 
> 
> Thanks,
> 
> Bernhard Scheirle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160822/deb7bfea/attachment.html>