Review Request 128655: VCardTool: parseDateTime and createDateTime refactoring

[Benni Hill]

> On Aug. 12, 2016, 6:56 vorm., Laurent Montel wrote:
> > No sure that I will able to validate it before my vacation (tomorrow morning)
> > I come back in 1 week.
> > 
> > Regards

OK. Enjoy your holiday!


- Benni


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128655/#review98317
-----------------------------------------------------------


On Aug. 12, 2016, 2:12 vorm., Benni Hill wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128655/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2016, 2:12 vorm.)
> 
> 
> Review request for KDEPIM-Libraries and Laurent Montel.
> 
> 
> Repository: kcontacts
> 
> 
> Description
> -------
> 
> - split createDateTime into createDate and createTime so they can be used separately to either export the date or the time. (createDateTime always exported the time because dateTime.time().isValid() returns true when dateTime has a valid date.)
> - parseDateTime now also recognizes offsets from UTC (e.g. +0100 or -12:30)
> - createDateTime can now write offsets from UTC
> - when parseDateTime can't parse the time *timeValid is set to false (I would like to use this in my next patch to prevent that the birthday field is parsed with a time when no time is present)
> - adjusted customidentifiertest and importexportvcardtest because they failed now
> - added some tests for createDateTime and parseDateTime (I had to make them public therefore)
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 9d8b4c0 
>   autotests/customidentifiertest.cpp f96defd 
>   autotests/datetimetest.h PRE-CREATION 
>   autotests/datetimetest.cpp PRE-CREATION 
>   autotests/importexportvcardtest.cpp c425b44 
>   src/vcardtool.h 2558c94 
>   src/vcardtool.cpp e3684ba 
> 
> Diff: https://git.reviewboard.kde.org/r/128655/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benni Hill
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160812/b81475e6/attachment.html>