<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128655/">https://git.reviewboard.kde.org/r/128655/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 12th, 2016, 6:56 vorm. CEST, <b>Laurent Montel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No sure that I will able to validate it before my vacation (tomorrow morning)
I come back in 1 week.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Regards</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK. Enjoy your holiday!</pre>
<br />
<p>- Benni</p>
<br />
<p>On August 12th, 2016, 2:12 vorm. CEST, Benni Hill wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDEPIM-Libraries and Laurent Montel.</div>
<div>By Benni Hill.</div>
<p style="color: grey;"><i>Updated Aug. 12, 2016, 2:12 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcontacts
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- split createDateTime into createDate and createTime so they can be used separately to either export the date or the time. (createDateTime always exported the time because dateTime.time().isValid() returns true when dateTime has a valid date.)
- parseDateTime now also recognizes offsets from UTC (e.g. +0100 or -12:30)
- createDateTime can now write offsets from UTC
- when parseDateTime can't parse the time *timeValid is set to false (I would like to use this in my next patch to prevent that the birthday field is parsed with a time when no time is present)
- adjusted customidentifiertest and importexportvcardtest because they failed now
- added some tests for createDateTime and parseDateTime (I had to make them public therefore)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(9d8b4c0)</span></li>
<li>autotests/customidentifiertest.cpp <span style="color: grey">(f96defd)</span></li>
<li>autotests/datetimetest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/datetimetest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/importexportvcardtest.cpp <span style="color: grey">(c425b44)</span></li>
<li>src/vcardtool.h <span style="color: grey">(2558c94)</span></li>
<li>src/vcardtool.cpp <span style="color: grey">(e3684ba)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128655/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>