[Kde-pim] Review Request 124988: Akonadi POP3 resource: Move to next state when there's no fetching to do

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124988/#review84867
-----------------------------------------------------------


Looks good to me, thanks!


resources/pop3/pop3resource.cpp (line 388)
<https://git.reviewboard.kde.org/r/124988/#comment58717>

    Are you sure? mIdsToDownload changes until line 379.


- Volker Krause


On Aug. 29, 2015, 10:19 p.m., Michael Pyne wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124988/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2015, 10:19 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> When trying to download POP3 messages there's a phase where the code seems to pare down the list based on which messages had already been obtained before.
> 
> This "pare down" process makes it possible to completely eliminate the need to download messages at all, but we don't check for this. Without the patch we create a fetch job with an ID to actually download, which seems to avoid causing serious problems (but does cause a mimetype not emitted warning from KJob, see RR#124987).
> 
> Instead, check to make sure we have messages to be fetched before issuing the job, and if not skip to the next stage ("Save"?). This is similar to the existing logic in case Save:.
> 
> 
> Diffs
> -----
> 
>   resources/pop3/pop3resource.cpp 2e608af 
> 
> Diff: https://git.reviewboard.kde.org/r/124988/diff/
> 
> 
> Testing
> -------
> 
> Same as RR #124987: I've successfully received POP3 messages with the new code, just without any weird warnings in the console output.
> 
> 
> Thanks,
> 
> Michael Pyne
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/