[Kde-pim] Review Request 124988: Akonadi POP3 resource: Move to next state when there's no fetching to do

[Michael Pyne]

> On Sept. 7, 2015, 5:22 a.m., Luca Beltrame wrote:
> > Please forwardport this to the relevant branch: there's the distinct possibility it will not be picked up, and besides there will be no more releases from the KDE/4.14 branch.
> 
> Michael Pyne wrote:
>     OK, I've drafted a couple of commits to apply to master for each repo, but will still need to install the rest of the KF5-based kdepim toolchain to test, unless it's OK to commit directly.

Both commits have been forward-ported to kdepimlibs and kdepim-runtime, which appear to still be the relevant repositories even for KF5.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124988/#review84927
-----------------------------------------------------------


On Sept. 6, 2015, 12:28 a.m., Michael Pyne wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124988/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2015, 12:28 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> When trying to download POP3 messages there's a phase where the code seems to pare down the list based on which messages had already been obtained before.
> 
> This "pare down" process makes it possible to completely eliminate the need to download messages at all, but we don't check for this. Without the patch we create a fetch job with an ID to actually download, which seems to avoid causing serious problems (but does cause a mimetype not emitted warning from KJob, see RR#124987).
> 
> Instead, check to make sure we have messages to be fetched before issuing the job, and if not skip to the next stage ("Save"?). This is similar to the existing logic in case Save:.
> 
> 
> Diffs
> -----
> 
>   resources/pop3/pop3resource.cpp 2e608af 
> 
> Diff: https://git.reviewboard.kde.org/r/124988/diff/
> 
> 
> Testing
> -------
> 
> Same as RR #124987: I've successfully received POP3 messages with the new code, just without any weird warnings in the console output.
> 
> 
> Thanks,
> 
> Michael Pyne
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/