[Kde-pim] Review Request 125710: Deal with akregator part main widget being externally deleted.

[Alex Merry]

> On Oct. 19, 2015, 9:13 p.m., Allen Winter wrote:
> > there is no code that deletes m_dialog now. is that correct?

Yes, it is a child of the main widget, so will be deleted along with that.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125710/#review87100
-----------------------------------------------------------


On Oct. 19, 2015, 7:07 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125710/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 7:07 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Running akregator under valgrind (to track down a different crash), I
> got that the main widget was deleted from the event loop (by
> qDeleteInEventHandler), which then triggered the deletion of the
> akregator part, which then tried to access the (now deleted) widget.
> 
> This should prevent the code from crashing in this case.
> 
> 
> Diffs
> -----
> 
>   akregator/src/akregator_part.cpp 185899c1f9987c091d01f8c8c025c229c9455891 
> 
> Diff: https://git.reviewboard.kde.org/r/125710/diff/
> 
> 
> Testing
> -------
> 
> Built, ran and quit akregator (both under valgrind and not).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/