[Kde-pim] Review Request 125710: Deal with akregator part main widget being externally deleted.

Alex Merry alex.merry at kde.org
Mon Oct 19 23:01:39 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125710/
-----------------------------------------------------------

(Updated Oct. 19, 2015, 10:01 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM and Laurent Montel.


Changes
-------

Submitted with commit 4f4e279e85fd9ebf2b8c29f31bf721df7ffeec6b by Alex Merry to branch master.


Repository: kdepim


Description
-------

Running akregator under valgrind (to track down a different crash), I
got that the main widget was deleted from the event loop (by
qDeleteInEventHandler), which then triggered the deletion of the
akregator part, which then tried to access the (now deleted) widget.

This should prevent the code from crashing in this case.


Diffs
-----

  akregator/src/akregator_part.cpp 185899c1f9987c091d01f8c8c025c229c9455891 

Diff: https://git.reviewboard.kde.org/r/125710/diff/


Testing
-------

Built, ran and quit akregator (both under valgrind and not).


Thanks,

Alex Merry

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list