[Kde-pim] Review Request 123773: Port KontactInterface away from KUniqueApplication (and KDELibs4Support)

[Daniel Vrátil]

> On May 13, 2015, 4:50 p.m., Aleix Pol Gonzalez wrote:
> > src/pimuniqueapplication.cpp, line 172
> > <https://git.reviewboard.kde.org/r/123773/diff/1/?file=368719#file368719line172>
> >
> >     wouldn't win->raise() be enough?

This came from KUniqueApplication::newInstance(), which had this call wrapped in `#ifdef Q_OS_WIN` . So the `win->show()` above is probably enough for Linux, but we need special treating for Windows apparently. I'll put back the #ifdef.


> On May 13, 2015, 4:50 p.m., Aleix Pol Gonzalez wrote:
> > src/uniqueapphandler.cpp, line 136
> > <https://git.reviewboard.kde.org/r/123773/diff/1/?file=368724#file368724line136>
> >
> >     Maybe it could be useful to make sense out of these arguments as well?

Not sure what you mean? This is the default implementation for activate(), which just raises the main window. If application is not interested in handling commandline arguments, it does not have to re-implement activate() at all and instead rely on this default implementation. And of course the default implementation cannot really understand the commandline arguments from different apps :)


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123773/#review80305
-----------------------------------------------------------


On May 13, 2015, 3:54 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123773/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 3:54 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Laurent Montel.
> 
> 
> Repository: kontactinterface
> 
> 
> Description
> -------
> 
> Port away from KUniqueApplication, use QApplication + manual DBus invocation instead (we can't use KDBusService either because it's not customizable enough for our needs). Basically the only change is renaming newInstance() to activate() (because we want to activate the running instance, right?) and passing list of arguments, because we no longer have the global static KCmdArgs and calling QApplication::arguments() is expensive (according to documentatation).
> 
> Another reason for renaming newIntance() to activate() is that I'm planning to use this call from individual application's systray icon implementations, which will allow us to automatically switch to the correct module in Kontact (i.e. right now when have "Calendar" active in Kontact, clicking on KMail systray icon restores Kontact window, but does not switch to KMail module - this will be possible with calling activate()).
> 
> 
> See dev/no-kuniqueapplication branch for commits.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 176c47f6d50e7a13daa5113f9574dde3528ce29e 
>   src/CMakeLists.txt a44afed97f8a83bbeaab8d0fc1e807c5d03cb2ac 
>   src/core.h 67837a93b481fcccf90aba04202580741cf68b83 
>   src/core.cpp 03afef28b27cb004ec92751e007792ee41133b0b 
>   src/pimuniqueapplication.h 875d561abeb3850593ba40476d2cb0c4c5bc0ad0 
>   src/pimuniqueapplication.cpp bbe4218c97dbc7ee2e38b2007d006ffd575d2624 
>   src/plugin.h 57f621ba7a47e1a852c2f5c12c3b67454a7ad520 
>   src/plugin.cpp bb1422e6b3323fd07aed56ee24e4f91621b11d21 
>   src/summary.cpp 15f123188ba14da4c7ad594bfdbb2b40f3928296 
>   src/uniqueapphandler.h 08185e5b073d8685f65cd4de7c23a7279c064e31 
>   src/uniqueapphandler.cpp 5fcf9cd859d4c9625d3cd16b76ead14c02f7d862 
> 
> Diff: https://git.reviewboard.kde.org/r/123773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/