[Kde-pim] Review Request 123773: Port KontactInterface away from KUniqueApplication (and KDELibs4Support)

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123773/
-----------------------------------------------------------

(Updated May 14, 2015, 2:15 p.m.)


Review request for KDEPIM-Libraries and Laurent Montel.


Repository: kontactinterface


Description
-------

Port away from KUniqueApplication, use QApplication + manual DBus invocation instead (we can't use KDBusService either because it's not customizable enough for our needs). Basically the only change is renaming newInstance() to activate() (because we want to activate the running instance, right?) and passing list of arguments, because we no longer have the global static KCmdArgs and calling QApplication::arguments() is expensive (according to documentatation).

Another reason for renaming newIntance() to activate() is that I'm planning to use this call from individual application's systray icon implementations, which will allow us to automatically switch to the correct module in Kontact (i.e. right now when have "Calendar" active in Kontact, clicking on KMail systray icon restores Kontact window, but does not switch to KMail module - this will be possible with calling activate()).


See dev/no-kuniqueapplication branch for commits.


Diffs (updated)
-----

  CMakeLists.txt df45f89 
  src/CMakeLists.txt 3a4b598 
  src/core.h 5a013c9 
  src/core.cpp 9cc3ef1 
  src/pimuniqueapplication.h 901e81a 
  src/pimuniqueapplication.cpp 3f9f027 
  src/plugin.h 9dc7cb8 
  src/plugin.cpp f8b9eaf 
  src/summary.cpp 34d1ef7 
  src/uniqueapphandler.h 14f884a 
  src/uniqueapphandler.cpp b5649cb 

Diff: https://git.reviewboard.kde.org/r/123773/diff/


Testing
-------


Thanks,

Daniel Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/