[Kde-pim] Review Request 123541: kolab patches: accountwizard

Sandro Knauß knauss at kolabsys.com
Fri May 8 10:48:14 BST 2015


Hey,

The tests need a more controlled env, but the all pass. In my "normal" KDE4 
debian unstable env the tests also fails with same error. If I rerun the tests 
via my testuser, they all pass [1]. I think the tricky part is the faking the 
server. For that I use file:// urls for testing the parsing parts. because 
ispdb passes this part works). And for testing the logic, to ask other 
servers, i implement a small python script (errorserver.py), that awnsers with 
the HTTP status code:

http://localhost:8000/500 -> with fail with HTTP status 500

This python server is started from the scripts in initTestCase. And it is  
checked that the server is running:
QCOMPARE(process.state(), QProcess::Running);

But somehow the server do not get any request within a normal env.

I think the problem is some how related with kded4 vs kded5 at the same dbus 
session. Thats why the trick with ssh -X  testuser at localhost works.

Regads,

sandro

--

[1]  $ ssh -X kdetest at localhost
$ make test
makeobj[0]: Entering directory `build/kdepim/accountwizard'
Running tests...
Test project /build/kdepim/accountwizard
    Start 1: ispdbtest
1/5 Test #1: ispdbtest ........................   Passed    0.51 sec
    Start 2: autoconfigkolabmailtest
2/5 Test #2: autoconfigkolabmailtest ..........   Passed    1.25 sec
    Start 3: autoconfigkolabldaptest
3/5 Test #3: autoconfigkolabldaptest ..........   Passed    1.10 sec
    Start 4: autoconfigkolabfreebusytest
4/5 Test #4: autoconfigkolabfreebusytest ......   Passed    1.11 sec
    Start 5: ldaptest
5/5 Test #5: ldaptest .........................   Passed    0.74 sec

100% tests passed, 0 tests failed out of 5

Total Test time (real) =   4.71 sec
makeobj[0]: Leaving directory `build/kdepim/accountwizard'



--
Am Freitag, 8. Mai 2015, 11:06:30 schrieb Sandro Knauß:
> Moin,
> 
> > https://paste.kde.org/pugggirl1
> > Did you test autotest before to commit ?
> > I have 3 errors now.
> 
> I did test it before and they passed. But today I recompile and retry and
> have 3 errors, too. I must ran anyhow a old version of the tests *grmpf*
> 
> I'll fix them.
> 
> Regads,
> 
> sandro

-- 
Sandro Knauß
Software Developer

Kolab Systems AG
Zürich, Switzerland

e: knauss at kolabsystems.com
t: +41 43 501 66 91
w: https://kolabsystems.com

pgp: CE81539E Sandro Knauß
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20150508/0ebcfbef/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list