[Kde-pim] Review Request 123541: kolab patches: accountwizard

[Sandro Knauß]

Hey,

> > The tests need a more controlled env, but the all pass. In my "normal"
> > KDE4
> > debian unstable env the tests also fails with same error.
> 
> So we need a problem if we can't execute it correctly no ?

well running tests for kf5 under a KDE4 env is no recommended way. That's why 
i don't see anything to improve here, if it is only valid for a KDE4 env. As I 
said, the problem is sofar, that the test request a network connection and, 
this one isn't handled.


> The problem that it doesn't work in ssh -X here.
> I use it for testing it.
> So it needs to be improved to be sure that we can launch "make test" without
> error.

Do you have a clean kf5 env? without anything running kde4 parts? Actually ssh 
-X isn't the only thing i changed - I also update the complete env to point to 
the inst dir of KF5.

Regards,

sandro

-- 
Sandro Knauß
Software Developer

Kolab Systems AG
Zürich, Switzerland

e: knauss at kolabsystems.com
t: +41 43 501 66 91
w: https://kolabsystems.com

pgp: CE81539E Sandro Knauß
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20150513/79cf0d2b/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/