[Kde-pim] Review Request 123774: Port PIM applications to new PimUniqueApplication API

Laurent Montel montel at kde.org
Thu May 14 09:11:44 BST 2015 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123774/#review80329
-----------------------------------------------------------



akregator/src/aboutdata.cpp (line 42)
<https://git.reviewboard.kde.org/r/123774/#comment55109>

    USe QStringLiteral



akregator/src/akregator_options.h (line 38)
<https://git.reviewboard.kde.org/r/123774/#comment55110>

    REplace all QLatin1String to QStringLiteral where necessary



akregator/src/articleviewer.cpp (line 692)
<https://git.reviewboard.kde.org/r/123774/#comment55111>

    QString -> QStringLiteral



akregator/src/main.cpp (line 66)
<https://git.reviewboard.kde.org/r/123774/#comment55112>

    Same here QStringLiteral



kaddressbook/aboutdata.cpp (line 35)
<https://git.reviewboard.kde.org/r/123774/#comment55113>

    Same here.
    Ok all in patch replace QLatin1String by QStringLiteral



kmail/kmkernel.cpp (line 313)
<https://git.reviewboard.kde.org/r/123774/#comment55114>

    Two QLatin1String ?:) => QStringLiteral


- Laurent Montel


On mai 13, 2015, 9:19 après-midi, Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123774/
> -----------------------------------------------------------
> 
> (Updated mai 13, 2015, 9:19 après-midi)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Switching PimUniqueApplication from KUniqueApplication to QApplication means that we have to ditch some KDELibs4Support components - mostly it means switching to QCommandLineParser and KAboutData. We also must make sure that there are no kapp (or KApplication::instance()) calls in those apps, as that returns null pointer now.
> 
> In case of Kontact I decided to port it to PimUniqueApplication too, as that gives us nice feature: switching Kontact modules from commandline (e.g. running kontact --module kmailplugin will switch to KMail in a running instance of Kontact).
> 
> see dev/no-kuniqueapplication for individual commits
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3518ea90bb8e38fa86a2cdda2af1b39304943979 
>   akregator/kontactplugin/akregator_plugin.h 0ff6874ee2875afcadb7415e2ea2a6d6c328f9d9 
>   akregator/kontactplugin/akregator_plugin.cpp 0410f1779b9fa943c8b9b5b4ead61088c5380a31 
>   akregator/kontactplugin/akregatorplugin.desktop 5394dfdc86d99562d776d8218184b83098473c17 
>   akregator/src/aboutdata.h a9f604bcd04405451b9918f474b772360adec8ba 
>   akregator/src/aboutdata.cpp 3ce29e3e8b855a08dcc6ea8a0d2d2c31cc2404af 
>   akregator/src/akregator_options.h 861a6fea073cf2d97c27738514294da63074bd44 
>   akregator/src/akregator_part.h 2e2cefcc855d162f46c1d14547bf3e6df49494a6 
>   akregator/src/akregator_part.cpp b40b3399ceb15b50f498fc61c54c8f4b960c38b4 
>   akregator/src/articleviewer.cpp fc5d9b9d6931ba800ccef24fb82bf84204f1336b 
>   akregator/src/main.cpp 54c3d7789341a578ffab2eb5ea7996a333f565fb 
>   akregator/src/mainwindow.cpp bbe48b1a1e22306337b562575e3a1bb8d64438a3 
>   akregator/src/org.kde.akregator.part.xml 33cf08b49ce1a2a69d650a83281fedde74a4a286 
>   akregator/src/tabwidget.cpp 68b2ac246be8c6762e46bff73f951016e1dcef6a 
>   kaddressbook/aboutdata.h c5d8068561e80a4af6d3131d6a4cc2b3a4bcacd6 
>   kaddressbook/aboutdata.cpp d12b57c66a3cd35dd396305cb9377274fffdf7ed 
>   kaddressbook/kaddressbook_options.h 2bd025792ace931542fda9c071ad2d83c1ad922b 
>   kaddressbook/kontactplugin/CMakeLists.txt bbb8f2bd8dbebbe58c5c80db80535648f36c2b24 
>   kaddressbook/kontactplugin/kaddressbook_plugin.h af11bbc4c30e8875dfa64ee86aa49378c5b49fc7 
>   kaddressbook/kontactplugin/kaddressbook_plugin.cpp 538e721f23af0441a44ada16a209740949eb3f93 
>   kaddressbook/main.cpp 07f74b481118f9bc2e95265c347c3f10fe38261a 
>   kaddressbook/mainwidget.h ee9271ff92de2d1749d2c83328e9ad2f13674ad9 
>   kaddressbook/mainwidget.cpp 80f371f8956330aab912bfbef46dfff2dcc46b18 
>   kaddressbook/org.kde.kaddressbook.xml 0b6d6adddf857580df2b29fbbf01d6c92b7b0e8b 
>   kmail/aboutdata.h 39185d4ef9fa98266b0b0ee238911ab677f3d157 
>   kmail/aboutdata.cpp bdcb8cef9e66fcec733f12dee50499f1b1f54cdc 
>   kmail/editor/kmcomposewin.cpp 30c3b298a759e3035b9484ea2240d778e6369c62 
>   kmail/kmail_options.h ee8902940f90a6d6c5311fd5626b7dd71ccea560 
>   kmail/kmkernel.h 66f43501f9e70c1b2b1505d231d0633ac319f0c0 
>   kmail/kmkernel.cpp b6aae15864266e44d7d9ff8f6af5e75d6fb95cf2 
>   kmail/kmmainwin.cpp ed6d028330834803a93ec9389c5049220f72df05 
>   kmail/kontactplugin/kmail_plugin.h ad6a8eeecd4f01e57a935a5c38343ae4f374f0e4 
>   kmail/kontactplugin/kmail_plugin.cpp a0aed6c76560a716856b4cb908bc46b62b5cae38 
>   kmail/main.cpp 7ef071a602a4c44b101fe1f200213bc50d2aeebb 
>   knotes/apps/application.h 281e261ef919484acdb8d6a64a902889962b9bb3 
>   knotes/apps/application.cpp a8225b94a71ff352ea5b3ce158b6beb438fd9825 
>   knotes/apps/knotes_options.h f4063e8a34978de6d60a8ba8fe0b3147cdd3929c 
>   knotes/apps/knotesapp.cpp db9911d7bf2deeca49e90704d47f1ff74e56fcdf 
>   knotes/apps/main.cpp 946d520627a67beea08b68170d19061389e0fecb 
>   knotes/kontactplugin/knotes_plugin.h cfab5a872be56fa0f6cfb370cc67e17b20ba8015 
>   knotes/kontactplugin/knotes_plugin.cpp c605a4560d70849f792e848171eeee49f3a7f7c0 
>   knotes/kontactplugin/knotesplugin.desktop eeec51c4f642d1b754b8fbf00e4577f5dcc05560 
>   knotes/notes/knote.cpp 56ae2134ac82954669592d4ae8ec5cc0c671c1f7 
>   kontact/src/CMakeLists.txt c8575e94799bbabad3af656541e787450a7e4424 
>   kontact/src/main.cpp 81ccd8650b92897000bd40152ebf1fcb29078b16 
>   kontact/src/mainwindow.cpp b5f48aaa40ef26f20d35afec7b1b11655ac63654 
>   korganizer/aboutdata.h 62dfaa72f7e0e9cbed59a9567666099822f9c62a 
>   korganizer/aboutdata.cpp 8817b08ae34a3a5404eb3ea0608a0d2544c135ed 
>   korganizer/actionmanager.h 87270d77878f6886cf74174c89fb6b7e1d1b2286 
>   korganizer/actionmanager.cpp 10f529d731907231ba2f5dbd460468ce34d0e7c3 
>   korganizer/data/org.kde.korganizer.Korganizer.xml 014e52558583b9166f37bc73cf11fe9e2fe63e5c 
>   korganizer/impl/korganizerifaceimpl.h dbecd473f119f8f0cd85e1c58bd3521a92015479 
>   korganizer/impl/korganizerifaceimpl.cpp 0180f348bd7eb0a6997dab26c1760adfa5b69788 
>   korganizer/koapp.h cc2be98521cfc7a054d6e7542010e00c05a15010 
>   korganizer/koapp.cpp afa844c2ee50a0b5c2d4bf73b9c5303837f12766 
>   korganizer/kontactplugin/korganizer/CMakeLists.txt 2e61d7e02caeb6e1c4338b3e1a30fd11252cbe31 
>   korganizer/kontactplugin/korganizer/korg_uniqueapp.h a964f2449ce1125b6d46e98892b299285c0afd62 
>   korganizer/kontactplugin/korganizer/korg_uniqueapp.cpp 9bad546f72d20179207bce09e4585d3ec18f70f8 
>   korganizer/korganizer_options.h b4786b426d6a75249e51bd0bf41c43e3d53b2e7f 
>   korganizer/korganizer_part.cpp ea1ef7379c9cbba3017b9e5b4d17ae263488585d 
>   korganizer/main.cpp f45b27bdf64fb28e7a7ff5fc754a39640300cc17 
> 
> Diff: https://git.reviewboard.kde.org/r/123774/diff/
> 
> 
> Testing
> -------
> 
> - start $PIMapp
> - minimize it
> - run $PIMapp from terminal
> - the running instance is restored, the new instance quits immediatelly
> 
> 
> - start Kontact
> - rum $PIMapp from terminal
> - Kontact is restored and switches to respective module
> 
> 
> - start $PIMapp
> - minimize it
> - start Kontact
> - select $PIMapp in Kontact
> - $PIMapp window is opened
> - select another app in Kontact
> - quit $PIMapp
> - select $PIMapp in Kontact
> - $PIMapp is loaded in Kontact
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

More information about the kde-pim mailing list