[Kde-pim] Review Request 123774: Port PIM applications to new PimUniqueApplication API

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123774/
-----------------------------------------------------------

(Updated May 14, 2015, 11:51 a.m.)


Review request for KDEPIM and Laurent Montel.


Changes
-------

QLatin1String -> QStringLiteral (although I don't believe any of this code is so performance critical to really justify the increased size of the binary)


Repository: kdepim


Description
-------

Switching PimUniqueApplication from KUniqueApplication to QApplication means that we have to ditch some KDELibs4Support components - mostly it means switching to QCommandLineParser and KAboutData. We also must make sure that there are no kapp (or KApplication::instance()) calls in those apps, as that returns null pointer now.

In case of Kontact I decided to port it to PimUniqueApplication too, as that gives us nice feature: switching Kontact modules from commandline (e.g. running kontact --module kmailplugin will switch to KMail in a running instance of Kontact).

see dev/no-kuniqueapplication for individual commits


Diffs (updated)
-----

  CMakeLists.txt ec3a582177b93416722e1c95381952531fe05ae5 
  akregator/kontactplugin/akregator_plugin.h 66bc79a12d6bb9a67b78941175ee25f71b2cb1fe 
  akregator/kontactplugin/akregator_plugin.cpp 04de98dbd44d3b6d930bf9f8e3b3e5316179cfc9 
  akregator/kontactplugin/akregatorplugin.desktop 74f2b7c4fe02c5c99b74db2fcf6ed7929e15d2af 
  akregator/src/aboutdata.h d978c347be191caf86cfb0374c57ddb890b4a2d1 
  akregator/src/aboutdata.cpp 4f27ff6887d057dda4f7eff422954f219fd4b6fb 
  akregator/src/akregator_options.h 20d228cdeacc401b822f1d3baaeee47181babd86 
  akregator/src/akregator_part.h 466ddb3d9f25c8afe577ca3a039256861a0f751e 
  akregator/src/akregator_part.cpp 40d834ebf25d2717c8ff05dfd084ae343a4f9694 
  akregator/src/articleviewer.cpp df1ae31f1545cf43c268b81426237e0143cb413f 
  akregator/src/main.cpp 4b4854e38a6ee7c33e12a0de6907b9d0b67d6287 
  akregator/src/mainwindow.cpp ef409977701b8b5422ff7f0c0b5fba6ab89851c7 
  akregator/src/org.kde.akregator.part.xml bcfd0aff014f2e8cd45d1d0b7992a0511c71da54 
  akregator/src/tabwidget.cpp 9c6b020118366b8b71917fc67c5001e3c8e00f4e 
  kaddressbook/aboutdata.h 5d51fc973d30643e5785682eec6aeec5f049474e 
  kaddressbook/aboutdata.cpp 4b53539084b4bc620cfe2732c35e8f4ed919b2b0 
  kaddressbook/kaddressbook_options.h 0869d29985cf3e3e866bfefc4b83a791555a199c 
  kaddressbook/kontactplugin/CMakeLists.txt 58475fc090a6647f174efc8cc7abb7060648c567 
  kaddressbook/kontactplugin/kaddressbook_plugin.h 071a3e042ea54e390dbb8f3659e151054d622af5 
  kaddressbook/kontactplugin/kaddressbook_plugin.cpp fa6d73816ea26096ebf50dfeb2809578f2d519c5 
  kaddressbook/main.cpp cc41665c3344580ca60d053f97b06fb30697e9ed 
  kaddressbook/mainwidget.h 8bade94285fbdf7ce6caf3a74d61ff2de28d9b8f 
  kaddressbook/mainwidget.cpp c38d20d7de314fa68f863461e63b90950e684a4a 
  kaddressbook/org.kde.kaddressbook.xml 1415b67a727890d2782698c4aa56e9fbde971dcb 
  kmail/aboutdata.h 60a62ec0e80debfd573534c840df907024f982be 
  kmail/aboutdata.cpp d7f00f728045c592c921aa2564f9f32962ac43a0 
  kmail/editor/kmcomposewin.cpp f14683f70bd52a150a0183c6f31124cf3e95bc07 
  kmail/kmail_options.h f509d23b299fe3429624ba5088e5dd311e1991aa 
  kmail/kmkernel.h 084179891c10d6f311fb2c1cf128e16029e0d91a 
  kmail/kmkernel.cpp 7841badca443774d4c5e2aab743a7aee816bd212 
  kmail/kmmainwin.cpp a75d479a4e86a2ed27eca3f3b3d4086dddbf98b5 
  kmail/kontactplugin/kmail_plugin.h 4a4a4e19f70c51d448b6568ef6dec9b4846f5793 
  kmail/kontactplugin/kmail_plugin.cpp a710d8dc5d7da7379353df4dd057676eb1b86770 
  kmail/main.cpp 7c15c07d98f398365873891cb289673cb6be146f 
  knotes/apps/application.h 4b4b9478a72bf62093bbe72ac104860fbf629ed5 
  knotes/apps/application.cpp 05cd66b233b37384c6365a5906d0b64b02160565 
  knotes/apps/knotes_options.h 76e18ed423b2477f223530b9f0e886ace7c338c2 
  knotes/apps/knotesapp.cpp ebe6cf08623c9eea3880c5ec06542a9071164da8 
  knotes/apps/main.cpp 8471511f52bbe14361f38c79cc15aa1597cc4577 
  knotes/kontactplugin/knotes_plugin.h 9fc0c8a92df5f52c51d072a1c860aa477efcbc5a 
  knotes/kontactplugin/knotes_plugin.cpp 5097824e4c0798689f1699ce3084b7597c812b9c 
  knotes/kontactplugin/knotesplugin.desktop 9c319050728a1bfffb052b7262f9bc095ff72a9f 
  knotes/notes/knote.cpp 4bc9ff8426d6ee1336d7ca989f961729d9137c51 
  kontact/src/CMakeLists.txt 1153224abaa38fab8d5fdb9fefe870577150d41b 
  kontact/src/main.cpp bfe331f426ebff6133c102896b979a8ffc80fa01 
  kontact/src/mainwindow.cpp 4dbc8c8cbcc3219940fe9356c278d372ba678781 
  korganizer/aboutdata.h 457152ddd86f6d93849284b47b9bf5b9af744c17 
  korganizer/aboutdata.cpp c19b178773f62f501df0504b644a20c73d3ad414 
  korganizer/actionmanager.h 4f537d85e024cbd55d4dd634182b4ee6e3fdb737 
  korganizer/actionmanager.cpp f265fc6bd73918b6a432a182b0945a5f1644886b 
  korganizer/data/org.kde.korganizer.Korganizer.xml 7f3a187de49dfad2a5ebac3a6384828baa61a904 
  korganizer/impl/korganizerifaceimpl.h 7ce859922b303f0773e35c9bb534fc7252ffa6aa 
  korganizer/impl/korganizerifaceimpl.cpp 2dd1f8a6f738d5a2614b3529f4d822d389d0e164 
  korganizer/koapp.h 2ae1db26f0d4ee81d9c27a62b4097b0794094fe8 
  korganizer/koapp.cpp 5fbee1c2b49b05c0297473efd691e07677570cd6 
  korganizer/kontactplugin/korganizer/CMakeLists.txt 5028863bc251b580d7418d2f1678bfc669ee1fde 
  korganizer/kontactplugin/korganizer/korg_uniqueapp.h 938474241a4524c5a240ac8c50080e03d1c26f48 
  korganizer/kontactplugin/korganizer/korg_uniqueapp.cpp fbea097b3fba4f097d89ba07134c1a9324b9a64a 
  korganizer/korganizer_options.h 26b85bef037a1b8cdb90f4d20d0c2b7be54316ee 
  korganizer/korganizer_part.cpp 14c88012f8b2995c06fc5b4a57a7d5786f64f111 
  korganizer/main.cpp a0410f5e09a558a1e14d1f0d6ae2efba9823b3af 

Diff: https://git.reviewboard.kde.org/r/123774/diff/


Testing
-------

- start $PIMapp
- minimize it
- run $PIMapp from terminal
- the running instance is restored, the new instance quits immediatelly


- start Kontact
- rum $PIMapp from terminal
- Kontact is restored and switches to respective module


- start $PIMapp
- minimize it
- start Kontact
- select $PIMapp in Kontact
- $PIMapp window is opened
- select another app in Kontact
- quit $PIMapp
- select $PIMapp in Kontact
- $PIMapp is loaded in Kontact


Thanks,

Daniel Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/