[Kde-pim] Review Request 123773: Port KontactInterface away from KUniqueApplication (and KDELibs4Support)

[Laurent Montel]

> On mai 14, 2015, 12:07 après-midi, Laurent Montel wrote:
> > src/uniqueapphandler.cpp, line 96
> > <https://git.reviewboard.kde.org/r/123773/diff/1/?file=368724#file368724line96>
> >
> >     Do you want to reactivate it ?
> 
> Daniel Vrátil wrote:
>     Yes: the entire point of qCDebug() is not to have to comment/uncomment debug messages in the code all the time. Instead we can just disable kontactinterface_log.debug *by default* and only turn it on via your tool, or via cmdline, right?

indeed we can.


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123773/#review80343
-----------------------------------------------------------


On mai 14, 2015, 12:24 après-midi, Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123773/
> -----------------------------------------------------------
> 
> (Updated mai 14, 2015, 12:24 après-midi)
> 
> 
> Review request for KDEPIM-Libraries and Laurent Montel.
> 
> 
> Repository: kontactinterface
> 
> 
> Description
> -------
> 
> Port away from KUniqueApplication, use QApplication + manual DBus invocation instead (we can't use KDBusService either because it's not customizable enough for our needs). Basically the only change is renaming newInstance() to activate() (because we want to activate the running instance, right?) and passing list of arguments, because we no longer have the global static KCmdArgs and calling QApplication::arguments() is expensive (according to documentatation).
> 
> Another reason for renaming newIntance() to activate() is that I'm planning to use this call from individual application's systray icon implementations, which will allow us to automatically switch to the correct module in Kontact (i.e. right now when have "Calendar" active in Kontact, clicking on KMail systray icon restores Kontact window, but does not switch to KMail module - this will be possible with calling activate()).
> 
> 
> See dev/no-kuniqueapplication branch for commits.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt df45f89 
>   src/CMakeLists.txt 3a4b598 
>   src/core.h 5a013c9 
>   src/core.cpp 9cc3ef1 
>   src/pimuniqueapplication.h 901e81a 
>   src/pimuniqueapplication.cpp 3f9f027 
>   src/plugin.h 9dc7cb8 
>   src/plugin.cpp f8b9eaf 
>   src/summary.cpp 34d1ef7 
>   src/uniqueapphandler.h 14f884a 
>   src/uniqueapphandler.cpp b5649cb 
> 
> Diff: https://git.reviewboard.kde.org/r/123773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/