[Kde-pim] Review Request 123541: kolab patches: accountwizard

[laurent Montel]

Le Friday 08 May 2015 11:48:14 Sandro Knauß a écrit :
> Hey,

> The tests need a more controlled env, but the all pass. In my "normal" KDE4
> debian unstable env the tests also fails with same error.

So we need a problem if we can't execute it correctly no ?

> If I rerun the
> tests via my testuser, they all pass [1]. I think the tricky part is the
> faking the server. For that I use file:// urls for testing the parsing
> parts. because ispdb passes this part works). And for testing the logic, to
> ask other servers, i implement a small python script (errorserver.py), that
> awnsers with the HTTP status code:
> 
> http://localhost:8000/500 -> with fail with HTTP status 500
> 
> This python server is started from the scripts in initTestCase. And it is
> checked that the server is running:
> QCOMPARE(process.state(), QProcess::Running);
> 
> But somehow the server do not get any request within a normal env.
> 
> I think the problem is some how related with kded4 vs kded5 at the same dbus
> session. Thats why the trick with ssh -X  testuser at localhost works.

The problem that it doesn't work in ssh -X here.
I use it for testing it.
So it needs to be improved to be sure that we can launch "make test" without 
error.

Regards

> 
> Regads,
> 
> sandro
> 
> --
> 
> [1]  $ ssh -X kdetest at localhost
> $ make test
> makeobj[0]: Entering directory `build/kdepim/accountwizard'
> Running tests...
> Test project /build/kdepim/accountwizard
>     Start 1: ispdbtest
> 1/5 Test #1: ispdbtest ........................   Passed    0.51 sec
>     Start 2: autoconfigkolabmailtest
> 2/5 Test #2: autoconfigkolabmailtest ..........   Passed    1.25 sec
>     Start 3: autoconfigkolabldaptest
> 3/5 Test #3: autoconfigkolabldaptest ..........   Passed    1.10 sec
>     Start 4: autoconfigkolabfreebusytest
> 4/5 Test #4: autoconfigkolabfreebusytest ......   Passed    1.11 sec
>     Start 5: ldaptest
> 5/5 Test #5: ldaptest .........................   Passed    0.74 sec
> 
> 100% tests passed, 0 tests failed out of 5
> 
> Total Test time (real) =   4.71 sec
> makeobj[0]: Leaving directory `build/kdepim/accountwizard'
> 
> 
> 
> --
> 
> Am Freitag, 8. Mai 2015, 11:06:30 schrieb Sandro Knauß:
> > Moin,
> > 
> > > https://paste.kde.org/pugggirl1
> > > Did you test autotest before to commit ?
> > > I have 3 errors now.
> > 
> > I did test it before and they passed. But today I recompile and retry and
> > have 3 errors, too. I must ran anyhow a old version of the tests *grmpf*
> > 
> > I'll fix them.
> > 
> > Regads,
> > 
> > sandro

-- 
Laurent Montel | laurent.montel at kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53,  http://www.kdab.fr


_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/