[Kde-pim] Review Request 123541: kolab patches: accountwizard

[laurent Montel]

Le Wednesday 13 May 2015 10:33:00 Sandro Knauß a écrit :
> Hey,
> 
> > > The tests need a more controlled env, but the all pass. In my "normal"
> > > KDE4
> > > debian unstable env the tests also fails with same error.
> > 
> > So we need a problem if we can't execute it correctly no ?
> 
> well running tests for kf5 under a KDE4 env is no recommended way.

I don't do it.
I use a specific user for it.

> That's
> why i don't see anything to improve here, if it is only valid for a KDE4
> env. As I said, the problem is sofar, that the test request a network
> connection and, this one isn't handled.
> 
> > The problem that it doesn't work in ssh -X here.
> > I use it for testing it.
> > So it needs to be improved to be sure that we can launch "make test"
> > without error.
> 
> Do you have a clean kf5 env? without anything running kde4 parts?

Yep a specific kf5 environment.

> Actually
> ssh -X isn't the only thing i changed - I also update the complete env to
> point to the inst dir of KF5.
> 
> Regards,
> 
> sandro

-- 
Laurent Montel | laurent.montel at kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53,  http://www.kdab.fr


_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/