[Kde-pim] Review Request 122933: KMIME: Do not add additional newlines, while parsing mails.

[Sandro Knauß]

> On März 14, 2015, 12:19 nachm., Laurent Montel wrote:
> > kmime/tests/auto/messagetest.cpp, line 464
> > <https://git.reviewboard.kde.org/r/122933/diff/1/?file=354835#file354835line464>
> >
> >     why replace decodeText but encodedBody and you have same line line 466 ?

you are right i have copied line 464 and 466. one can be deleted.

Well in the end this change of decodedText from "Bla Bla Bla\n" -> "Bla Bla Bla" is one side change.

But I think it is okay, because l477f (old) warn about the problem that a new line is added by kmime.

QEXPECT_FAIL( "", "KMime adds an additional newline", Continue );
QCOMPARE( msg2.decodedText().toLatin1().data(), "Bla Bla Bla\n" );

The basic thing I want to make sure is that dontchangemail.mbox isn't changed. This is the added test MessageTest::testReturnSameMail().
All further changes in tests are "side changes", that are not intend and only made for fixing the tests.

The change in contenttest is for sure ok, because it removes an addidional line added from versions before.

As far as I checked kdepim* decodedText is only used for notes and there the additional newline isn't something that is expected.


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122933/#review77464
-----------------------------------------------------------


On März 13, 2015, 9:24 nachm., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122933/
> -----------------------------------------------------------
> 
> (Updated März 13, 2015, 9:24 nachm.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Bugs: 332036 and 332973
>     http://bugs.kde.org/show_bug.cgi?id=332036
>     http://bugs.kde.org/show_bug.cgi?id=332973
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> If testing the signature status of mails, than nothing is allowed to
> change. Also not the number of newlines, that seperates head and body. So make sure that at least two are written.
> 
> BUG: 332036
> BUG: 332973
> FIXED-IN: 15.04
> 
> 
> Diffs
> -----
> 
>   kmime/kmime_content.cpp 7d30e1057fa6d56f08ebf788cfd71d9b03d5d111 
>   kmime/kmime_header_parsing.cpp 647370341c1f4874b952e2050fc2384d21bc7f78 
>   kmime/tests/auto/contenttest.cpp 772260c8f610f108a60e39de09423472acfe6e25 
>   kmime/tests/auto/messagetest.h d49ef9b6ff2d2de388adf211393e31aa3e917f99 
>   kmime/tests/auto/messagetest.cpp 1632f5988009a5d5cd039ed851f9ab19f576b867 
>   kmime/tests/data/mails/dontchangemail.mbox PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122933/diff/
> 
> 
> Testing
> -------
> 
> run make test
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/