[Kde-pim] Review Request 122933: KMIME: Do not add additional newlines, while parsing mails.

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122933/#review77494
-----------------------------------------------------------



kmime/kmime_content.cpp
<https://git.reviewboard.kde.org/r/122933/#comment53215>

    it will good to rename "e", "tmp" variable as a real name.
    
    because here e == head
    and tmp == encodedBody 
    
    e == headerData
    tmp == tmpEncodedBodyData  ?


- Laurent Montel


On mars 14, 2015, 2:10 après-midi, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122933/
> -----------------------------------------------------------
> 
> (Updated mars 14, 2015, 2:10 après-midi)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Bugs: 332036 and 332973
>     http://bugs.kde.org/show_bug.cgi?id=332036
>     http://bugs.kde.org/show_bug.cgi?id=332973
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> If testing the signature status of mails, than nothing is allowed to
> change. Also not the number of newlines, that seperates head and body. So make sure that at least two are written.
> 
> BUG: 332036
> BUG: 332973
> FIXED-IN: 15.04
> 
> 
> Diffs
> -----
> 
>   kmime/kmime_content.cpp 7d30e1057fa6d56f08ebf788cfd71d9b03d5d111 
>   kmime/kmime_header_parsing.cpp 647370341c1f4874b952e2050fc2384d21bc7f78 
>   kmime/tests/auto/contenttest.cpp 772260c8f610f108a60e39de09423472acfe6e25 
>   kmime/tests/auto/messagetest.h d49ef9b6ff2d2de388adf211393e31aa3e917f99 
>   kmime/tests/auto/messagetest.cpp 1632f5988009a5d5cd039ed851f9ab19f576b867 
>   kmime/tests/data/mails/dontchangemail.mbox PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122933/diff/
> 
> 
> Testing
> -------
> 
> run make test 
> 
> open the attached mails from 332036 and 332973 and test there signature status.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/