[Kde-pim] Review Request 124211: Fix inefficient algorithm

Sergio Luis Martins iamsergio at gmail.com
Mon Jun 29 18:59:06 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124211/
-----------------------------------------------------------

Review request for KDEPIM and Daniel Vrátil.


Repository: akonadi


Description
-------

3 iterations were being done:

1) .values() iterates the whole hash internally and creates a QList (memory allocations++)
2) .contains()
3) .key(value)

Instead, iterate only once


Diffs
-----

  src/server/collectionscheduler.cpp b77249d 

Diff: https://git.reviewboard.kde.org/r/124211/diff/


Testing
-------


Thanks,

Sergio Luis Martins

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list