[Kde-pim] Review Request 124211: Fix inefficient algorithm

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124211/#review81878
-----------------------------------------------------------

Ship it!


Ship It!

- Daniel Vrátil


On June 29, 2015, 7:59 p.m., Sergio Luis Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124211/
> -----------------------------------------------------------
> 
> (Updated June 29, 2015, 7:59 p.m.)
> 
> 
> Review request for KDEPIM and Daniel Vrátil.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> 3 iterations were being done:
> 
> 1) .values() iterates the whole hash internally and creates a QList (memory allocations++)
> 2) .contains()
> 3) .key(value)
> 
> Instead, iterate only once
> 
> 
> Diffs
> -----
> 
>   src/server/collectionscheduler.cpp b77249d 
> 
> Diff: https://git.reviewboard.kde.org/r/124211/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergio Luis Martins
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/