[Kde-pim] Review Request 124198: kmime: Remove unused ctors that called pure virtual functions

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124198/#review81812
-----------------------------------------------------------

Ship it!


- Laurent Montel


On juin 27, 2015, 11:12 matin, Sergio Luis Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124198/
> -----------------------------------------------------------
> 
> (Updated juin 27, 2015, 11:12 matin)
> 
> 
> Review request for KDEPIM, KDEPIM-Libraries and Volker Krause.
> 
> 
> Repository: kmime
> 
> 
> Description
> -------
> 
> Call wasn't direct, otherwise gcc would have warned.
> Ctor called from7BitString() which called pure virtual parse(), which would have crashed if this wasn't dead code.
> 
> 
> Diffs
> -----
> 
>   src/kmime_headers.h ffe087a 
>   src/kmime_headers.cpp 0a7f0a5 
> 
> Diff: https://git.reviewboard.kde.org/r/124198/diff/
> 
> 
> Testing
> -------
> 
> all still builds
> 
> 
> Thanks,
> 
> Sergio Luis Martins
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/