[Kde-pim] Review Request 124198: kmime: Remove unused ctors that called pure virtual functions

Sergio Luis Martins iamsergio at gmail.com
Sat Jun 27 12:47:42 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124198/
-----------------------------------------------------------

(Updated June 27, 2015, 11:47 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM, KDEPIM-Libraries and Volker Krause.


Changes
-------

Submitted with commit 37e1a0a561a93b713a642426da238160be008442 by Sergio Martins to branch master.


Repository: kmime


Description
-------

Call wasn't direct, otherwise gcc would have warned.
Ctor called from7BitString() which called pure virtual parse(), which would have crashed if this wasn't dead code.


Diffs
-----

  src/kmime_headers.h ffe087a 
  src/kmime_headers.cpp 0a7f0a5 

Diff: https://git.reviewboard.kde.org/r/124198/diff/


Testing
-------

all still builds


Thanks,

Sergio Luis Martins

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list