[Kde-pim] Review Request 124405: Make WebEngineWidgets an optional dependency for ksieveui/editor

[Laurent Montel]

> On juil. 20, 2015, 2:44 après-midi, Daniel Vrátil wrote:
> > We can easily revert back to QWebWeKit without losing any functionality - I actually sent a patch to Laurent this morning: https://paste.kde.org/pqtgxl74w - feel free to use it for the review :)
> 
> Laurent Montel wrote:
>     Yep I think that Dan patch is better.
>     Sorry I didnt have time for the moment to review it.
>     I will try tomorrow, for the moment I try to make it release for 15.08...

I prefere Dan patch indeed we don't lose any functionality.
Please commit Dan.
Regards


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124405/#review82715
-----------------------------------------------------------


On juil. 20, 2015, 1:50 après-midi, Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124405/
> -----------------------------------------------------------
> 
> (Updated juil. 20, 2015, 1:50 après-midi)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> After spending several hours on trying to get WebEngine built I gave up
> and thought it might be easier to turn the dependency optional. This
> is especially useful as many distributions are unable to provide this
> dependency.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c01eb0ca0a8b18b01a50091acc0c86088f25fe37 
>   config-kdepim.h.cmake 97e398afd5c482713734f6b4835c004bbddb7b42 
>   libksieve/ksieveui/CMakeLists.txt d429be3b1799c855828bd4e27faa6997ad668117 
>   libksieve/ksieveui/editor/sieveeditortabwidget.cpp e2e8fb632d79ae2f6ddb82956cef3b367a47d048 
> 
> Diff: https://git.reviewboard.kde.org/r/124405/diff/
> 
> 
> Testing
> -------
> 
> compiles without QtWebEngine, obviously not tried to compile with.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/