[Kde-pim] Review Request 124405: Make WebEngineWidgets an optional dependency for ksieveui/editor

Martin Gräßlin mgraesslin at kde.org
Tue Jul 21 06:50:23 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124405/
-----------------------------------------------------------

(Updated July 21, 2015, 7:50 a.m.)


Status
------

This change has been discarded.


Review request for KDEPIM and Laurent Montel.


Repository: kdepim


Description
-------

After spending several hours on trying to get WebEngine built I gave up
and thought it might be easier to turn the dependency optional. This
is especially useful as many distributions are unable to provide this
dependency.


Diffs
-----

  CMakeLists.txt c01eb0ca0a8b18b01a50091acc0c86088f25fe37 
  config-kdepim.h.cmake 97e398afd5c482713734f6b4835c004bbddb7b42 
  libksieve/ksieveui/CMakeLists.txt d429be3b1799c855828bd4e27faa6997ad668117 
  libksieve/ksieveui/editor/sieveeditortabwidget.cpp e2e8fb632d79ae2f6ddb82956cef3b367a47d048 

Diff: https://git.reviewboard.kde.org/r/124405/diff/


Testing
-------

compiles without QtWebEngine, obviously not tried to compile with.


Thanks,

Martin Gräßlin

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list