[Kde-pim] Review Request 122047: Fix encoding for non-ascii filenames for TNEF.

[Andreas Cord-Landwehr]

> On Jan. 14, 2015, 7:56 a.m., Laurent Montel wrote:
> > Seems good for me.
> > Ship it.
> > Are you able to build ktnef kf5 ? We need to backport in this directory too. We can't merge
> > If you don't have it I can do it for you.
> > 
> > Thanks.
> > 
> > 
> > We have "
> > "QDEBUG : ParserTest::testUmlautAttachmentFilenames() qttest(32699)/ktnef formatTime: Invalid date: low byte=2749186048, high byte=213075287
> > QDEBUG : ParserTest::testUmlautAttachmentFilenames() qttest(32699)/ktnef formatTime: Invalid date: low byte=2749186048, high byte=213075287
> > "
> > Will you able to debug it ? (in another patch this patch it ok for now)
> > 
> > Thanks.

Sure, I will port the patch for the kf5-version of ktnef as well as looking into the formatTime issues.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122047/#review73990
-----------------------------------------------------------


On Jan. 14, 2015, 6:40 a.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122047/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 6:40 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Correctly decode attachement filenames as Latin1. Adding a unit test
> to ensure this.
> 
> This patch is connected to review request 121937 that I will adapt, once this fix is committed.
> 
> 
> Diffs
> -----
> 
>   ktnef/ktnefparser.cpp 4faebaf 
>   ktnef/tests/parsertest.h 181a57e 
>   ktnef/tests/parsertest.cpp efa3053 
>   ktnef/tests/umlaut-filename.tnef PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122047/diff/
> 
> 
> Testing
> -------
> 
> unit test
> 
> 
> File Attachments
> ----------------
> 
> umlaut-filename.tnef
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/01/14/31da25a4-4528-4091-b575-3e7892697a3d__umlaut-filename.tnef
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/