[Kde-pim] Review Request 122047: Fix encoding for non-ascii filenames for TNEF.

Andreas Cord-Landwehr cordlandwehr at kde.org
Wed Jan 14 06:40:33 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122047/
-----------------------------------------------------------

(Updated Jan. 14, 2015, 6:40 vorm.)


Review request for KDEPIM.


Changes
-------

Seems, I do not manage to convince reviewboard to accept the binary file in my diff, so adding it as an additional file for now.


Repository: kdepimlibs


Description
-------

Correctly decode attachement filenames as Latin1. Adding a unit test
to ensure this.

This patch is connected to review request 121937 that I will adapt, once this fix is committed.


Diffs
-----

  ktnef/ktnefparser.cpp 4faebaf 
  ktnef/tests/parsertest.h 181a57e 
  ktnef/tests/parsertest.cpp efa3053 
  ktnef/tests/umlaut-filename.tnef PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122047/diff/


Testing
-------

unit test


File Attachments (updated)
----------------

umlaut-filename.tnef
  https://git.reviewboard.kde.org/media/uploaded/files/2015/01/14/31da25a4-4528-4091-b575-3e7892697a3d__umlaut-filename.tnef


Thanks,

Andreas Cord-Landwehr

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list