[Kde-pim] Review Request 122224: Use the new method Akonadi::MessageFlags::copyMessageFlags to remove code duplication and fix flags-bugs

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122224/#review74640
-----------------------------------------------------------



resources/mbox/mboxresource.cpp
<https://git.reviewboard.kde.org/r/122224/#comment51729>

    For each message you get the full message ?
    Do you test if it's impact on performances ?


- Laurent Montel


On jan. 23, 2015, 4:21 après-midi, Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122224/
> -----------------------------------------------------------
> 
> (Updated jan. 23, 2015, 4:21 après-midi)
> 
> 
> Review request for KDEPIM, KDEPIM-Libraries and Laurent Montel.
> 
> 
> Bugs: 286692, 313401, 327241, and 342756
>     http://bugs.kde.org/show_bug.cgi?id=286692
>     http://bugs.kde.org/show_bug.cgi?id=313401
>     http://bugs.kde.org/show_bug.cgi?id=327241
>     http://bugs.kde.org/show_bug.cgi?id=342756
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> As seen in the other review request, this patch uses the new method.
> But it also uses the method on places where it was missing before, leading to Akonadi entries without the flags, which are used e.g. in the mail list in kmail.
> 
> There are several bug entries on bko which relate to this problem
> 
> 
> Diffs
> -----
> 
>   resources/imap/messagehelper.cpp cf89315 
>   resources/maildir/maildirresource.cpp 390274d 
>   resources/maildir/retrieveitemsjob.cpp 8b6cca6 
>   resources/mbox/mboxresource.cpp 9b39870 
>   resources/mixedmaildir/mixedmaildirstore.cpp 1903c3a 
>   resources/pop3/pop3resource.cpp 4a1bd43 
> 
> Diff: https://git.reviewboard.kde.org/r/122224/diff/
> 
> 
> Testing
> -------
> 
> with kmail
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/