[Kde-pim] Review Request 122224: Use the new method Akonadi::MessageFlags::copyMessageFlags to remove code duplication and fix flags-bugs

[Martin Koller]

> On Jan. 23, 2015, 10:13 p.m., Laurent Montel wrote:
> > resources/mbox/mboxresource.cpp, line 141
> > <https://git.reviewboard.kde.org/r/122224/diff/1/?file=344371#file344371line141>
> >
> >     For each message you get the full message ?
> >     Do you test if it's impact on performances ?
> 
> Martin Koller wrote:
>     Do you see any other possibility here than to read the complete mail ?

I tested now with a huge 1,2GB mbox file (and found a memory leak in my patch...)

Yes of course reading the complete message has an impact, however I see no other way except not having the status flags correctly.
I think for a user it would not be clear to delay the detection of the flags (especially "has attachment" is a very commmon one)
until e.g. he clicks on the mail (as is done with IMAP), since he HAS the mbox file already completely available on disk.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122224/#review74640
-----------------------------------------------------------


On Jan. 24, 2015, 1:01 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122224/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2015, 1:01 p.m.)
> 
> 
> Review request for KDEPIM, KDEPIM-Libraries and Laurent Montel.
> 
> 
> Bugs: 286692, 313401, 327241, and 342756
>     http://bugs.kde.org/show_bug.cgi?id=286692
>     http://bugs.kde.org/show_bug.cgi?id=313401
>     http://bugs.kde.org/show_bug.cgi?id=327241
>     http://bugs.kde.org/show_bug.cgi?id=342756
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> As seen in the other review request, this patch uses the new method.
> But it also uses the method on places where it was missing before, leading to Akonadi entries without the flags, which are used e.g. in the mail list in kmail.
> 
> There are several bug entries on bko which relate to this problem
> 
> 
> Diffs
> -----
> 
>   resources/mbox/mboxresource.cpp 9b39870 
> 
> Diff: https://git.reviewboard.kde.org/r/122224/diff/
> 
> 
> Testing
> -------
> 
> with kmail
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/