[Kde-pim] Review Request 122713: Boost is required to build gpgmepp.

[Cristian Oneț]

> On Feb. 24, 2015, 11:51 p.m., Aleix Pol Gonzalez wrote:
> > .reviewboardrc, line 5
> > <https://git.reviewboard.kde.org/r/122713/diff/1/?file=351518#file351518line5>
> >
> >     I've only participated in the splitting, I don't mind being there but I have no gpgmepp specific knowledge. (TBH, I'm even unsure what it does).

Then you might want to remove yourself from the members of the project page https://projects.kde.org/projects/kde/pim/gpgmepp I thought you took over from Laurent by looking at that page.


On Feb. 24, 2015, 11:51 p.m., Cristian Oneț wrote:
> > How come hasn't this been picked up by Jenkins? Isn't it activated?
> > 
> > Anyway, the rest of the changes look good to me.

I suspect that on the Jenkins workers the boost headers and the gpgme headers are both installed under the same prefix (/usr/include). The prefix is picked up in the include path because of gpgme includes which makes #include <boost/shared_ptr> work without finding boost. I only caught this by trying to build it in an environment without boost headers. There could be other issues like this, Marko Käning sent you a mail (the same reason why I've added you to this review) about 'gpg-error.h' file not found. Now I'll look at that issue.


- Cristian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122713/#review76572
-----------------------------------------------------------


On Feb. 24, 2015, 10:54 p.m., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122713/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2015, 10:54 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Aleix Pol Gonzalez and Laurent Montel.
> 
> 
> Repository: gpgmepp
> 
> 
> Description
> -------
> 
> Without boost being checked for by the build system, the build will
> fail when using boost::shared_ptr if boost headers are not installed.
> 
> Also update project reviewboard settings based on the project description to be able to post this request.
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc db062f166f9e480133c10964ce0d0b7d446b46da 
>   CMakeLists.txt 91e04462e5be735f5e1aeb576f53b516518c6b5e 
> 
> Diff: https://git.reviewboard.kde.org/r/122713/diff/
> 
> 
> Testing
> -------
> 
> Built gpgmepp on Windows using MSVC 2013.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/