[Kde-pim] Review Request 122713: Boost is required to build gpgmepp.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122713/#review76572
-----------------------------------------------------------

Ship it!



.reviewboardrc
<https://git.reviewboard.kde.org/r/122713/#comment52743>

    I've only participated in the splitting, I don't mind being there but I have no gpgmepp specific knowledge. (TBH, I'm even unsure what it does).


How come hasn't this been picked up by Jenkins? Isn't it activated?

Anyway, the rest of the changes look good to me.

- Aleix Pol Gonzalez


On Feb. 24, 2015, 11:54 p.m., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122713/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2015, 11:54 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Aleix Pol Gonzalez and Laurent Montel.
> 
> 
> Repository: gpgmepp
> 
> 
> Description
> -------
> 
> Without boost being checked for by the build system, the build will
> fail when using boost::shared_ptr if boost headers are not installed.
> 
> Also update project reviewboard settings based on the project description to be able to post this request.
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc db062f166f9e480133c10964ce0d0b7d446b46da 
>   CMakeLists.txt 91e04462e5be735f5e1aeb576f53b516518c6b5e 
> 
> Diff: https://git.reviewboard.kde.org/r/122713/diff/
> 
> 
> Testing
> -------
> 
> Built gpgmepp on Windows using MSVC 2013.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/